Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #337
Before, the merchant's
close()
function calledfinalize_mutual_close
. Now, the merchant's watcher calls it.The most substantial change here is an addition of
MutualCloseBalances
to the merchant database. The merchant watcher cannot tell from the contract itself what the final mutual close balances are, so we need to persist them via the database instead. These changes includesqlx-data.json
is the generated file)Observation: the getters for each field of the database are a bit clumsy -- they're all identical except for the item being queried. Would it be better to have a single getter for the whole row, and have the caller pull out the field relevant to them?
Testing: I think this scenario is not currently caught by the e2e testing infrastructure. Should determine whether it is and either fix it in this PR or make a new issue + PR to address it.