Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for bonfire config concerning appName #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ahouchens
Copy link
Contributor

Closes #5

@vine77
Copy link
Member

vine77 commented May 6, 2015

Thanks for adding tests. However, this looks like you're asserting that the config values must always be present, when in reality we want bf-header to work with our without them in the consuming app's environment.js. And you might as well leave 'it renders'.

@ahouchens
Copy link
Contributor Author

This is where we may have confusion. I have the understanding that not all unit tests need to pass. These unit tests are for the cases for defining the config values if that functionality is desired.

I will add 'it renders' back in for a test case in the dummy app - good point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write test to check for bonfire.title config
2 participants