Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print verification coverage only when -trace used #770

Merged
merged 7 commits into from
Aug 14, 2023

Conversation

atomb
Copy link
Collaborator

@atomb atomb commented Aug 10, 2023

The -trackVerificationCoverage option enables tracking of verification coverage but the results are printed only when -trace is also provided. This makes it possible to see the results in text, but makes the output less noisy for clients of Boogie as a library (such as Dafny).

The -trackVerificationCoverage option enables tracking of verification
coverage but the results are printed only when -trace is also provided.
This makes it possible to see the results in text, but makes the output
less noisy for clients of Boogie as a library (such as Dafny).
@atomb atomb enabled auto-merge (squash) August 10, 2023 19:22
shazqadeer
shazqadeer previously approved these changes Aug 11, 2023
@shazqadeer
Copy link
Contributor

GC.bpl is timing out in one of the configurations. I have observed some flakiness in verification times for this example before. I found that /vcsSplitOnEveryAssert helps.

@atomb atomb dismissed stale reviews from shazqadeer and keyboardDrummer via 29854ff August 11, 2023 15:49
@shazqadeer
Copy link
Contributor

I will look into the flakiness of GC.bpl later. Meanwhile, if you need to merge this PR now, is there a way to override the merge requirements?

@atomb
Copy link
Collaborator Author

atomb commented Aug 11, 2023

It's not super urgent that I merge this PR. I'd like to do it by the end of next week, perhaps, but before then isn't critical. So if you fix it as part of a separate PR, this one should then go through after merging with master.

@shazqadeer
Copy link
Contributor

@atomb : I pushed a fix to GC.bpl. Looks good now.

@atomb atomb merged commit 82b9a4f into boogie-org:master Aug 14, 2023
4 checks passed
@atomb atomb deleted the coverage-trace branch January 4, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants