[Civl] bug fix for noninterference checking for pending asyncs #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkragl
reviewed
Aug 29, 2023
Comment on lines
-759
to
+761
| var pendingAsyncsToCheck = new HashSet<Action>( | ||
| civlTypeChecker.MoverActions | ||
| .Where(a => a.LayerRange.Contains(layerNum) && a.HasPendingAsyncs) | ||
| .SelectMany(a => a.PendingAsyncs).Select(a => civlTypeChecker.Action(a))); | ||
| var pendingAsyncsToCheck = | ||
| new HashSet<Action>(civlTypeChecker.MoverActions.Where(a => | ||
| a.LayerRange.Contains(layerNum) && a.ActionDecl.MaybePendingAsync)); |
There was a problem hiding this comment.
Just to confirm my understanding: We previously made the mistake of only checking noninterference against PAs that were created by actions. However, in your test case below it is procedure Foo that creates a PA at layer 2. We don't have a dedicated declaration of PAs created by procedures. Instead, we take the actions declared with async (which sets MaybePendingAsync?) and check noninterference at all their layers, irrespective of whether there are actually PAs created or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a particular layer number, those pending asyncs must be collected for which noninterference checking against yield invariants must be performed. The collection of pending asyncs was not sound earlier. This PR makes a fix to make it sound.