Fix crashes with verification coverage + counterexamples #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shazqadeer
approved these changes
Nov 29, 2023
| @@ -281,6 +281,9 @@ internal override void Run() | |||
| } | |||
| else | |||
| { | |||
| if (funName.StartsWith("aux$$")) { | |||
There was a problem hiding this comment.
Does the name aux$$ occur anywhere else in the code? Can we use a string constant to refer to it?
There was a problem hiding this comment.
Yes, it occurs in a small number of other places. We probably should create a string constant for it. I'll do that in a future refactoring.
keyboardDrummer
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, running Boogie with
/trackVerificationCoverageand/enhancedErrorMessages:1(or anything that leads to counterexample parsing) would lead to crashes when verification failed. This fixes that issue.