No cache #964
Merged
No cache #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyboardDrummer
requested review from
fabiomadge and
MikaelMayer
and removed request for
fabiomadge
keyboardDrummer
force-pushed
the
noCache
branch
from
304caae
to
7699a65
Compare
MikaelMayer
reviewed
Oct 11, 2024
|
|
||
| public void Insert(Implementation impl, ImplementationRunResult result) | ||
| { | ||
| Contract.Requires(result != null); |
There was a problem hiding this comment.
Suggested change
| Contract.Requires(result != null); | |
| Contract.Requires(impl != null); | |
| Contract.Requires(result != null); |
This contract was left out during refactoring. Or did you intend to remove both contracts?
The function Lookup, RemoveMatchingKeys and VerificationPriority below also had a contract removed.
There was a problem hiding this comment.
The presence of the contract creates a warning slightly further down in this method, because it implies impl can be null and this file uses #nullable enable. I had to remove the check because the warning makes the build fail.
The end-state we want is that all files use #nullable enable and there are no more Contract based non-null assertions.
MikaelMayer
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
EmptyVerificationResultCacheTesting