Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable marking if commands as {:allow_split} or not #967

Closed

Conversation

keyboardDrummer
Copy link
Collaborator

@keyboardDrummer keyboardDrummer commented Oct 16, 2024

Depends on #968

Changes

  • Fix concurrency issue that could create a crash when using multiple cores and simple programs (commit)
  • Introduce the attribute {:allow_split} that can be placed on IfCmd and GotoCmd. When using {:isolate "paths"} only, jumps with {:allow_split} will trigger splitting of the VC.
  • Make it so that when using {:vcs_split_on_every_assert}, no additional VCs are introduced for path that do not end in an explicit return. In additional, VCs introduced for explicit returns will only contain a single assertions, even when there are multiple ensures clauses.

Testing

  • Updated existing tests so they exercise the presence and absence of {:allow_split}
  • Added a test that combines {:vcs_split_on_every_assert} and explicit returns.

@keyboardDrummer keyboardDrummer changed the title Isolate paths take two Enable marking if commands as {:allow_split} or not Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant