Fix bug in datatype translation #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shazqadeer
force-pushed
the
random-naming-bug-fix
branch
from
ed8307e
to
df599c1
Compare
keyboardDrummer
approved these changes
Oct 25, 2024
|
Would be good to add a test as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SMTLib has a convention regarding the syntax for specifying the test for a variant arm of a datatype. If the variant constructor name is C, a call to function is-C must be generated. This was not being done correctly and this PR fixes the problem.
This PR also renames SmtLibNameUtils --> SMTLibNameUtils to match the convention used for other classes in the SMTLib project.