summarize: add support for 'count' and validate aggregation function #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avereha
requested review from
azhiltsov,
chrisGerken,
grlvrl and
grzkv
as code owners
grzkv
reviewed
Sep 25, 2020
grzkv
requested changes
Sep 25, 2020
grzkv
requested changes
Sep 25, 2020
avereha
force-pushed
the
avereha/summarize
branch
from
e7968d2
to
cb6a45f
Compare
grzkv
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue is this change attempting to solve?
summarize: add support for 'count' and validate aggregation function
How does this change solve the problem? Why is this the best approach?
Moved tests from expr_test to this function directory.
How can we be sure this works as expected?
Added test for 'count'