-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FE][Feat] #108 : Dropdown 버튼 구현 #153
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 세부적인 디테일 수정사항이 남아있음. - TODO에 배치
- App.tsx 삭제
juwon5272
previously approved these changes
Nov 13, 2024
컴포넌트가 세세히 잘 나누어져 있어서 좋은거 같습니다. Todo도 적혀있어서 다음 작업을 파악하기 쉬웠구요 |
Todos: - unmount 이미지 구현 - 아이콘 색상 들어가는 요소 수정 필요 - 링크 붙이기
leedongyull
approved these changes
Nov 13, 2024
effozen
commented
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인하였습니다.
juwon5272
approved these changes
Nov 13, 2024
effozen
added
작업 완료
PR이 제대로 되어 approve 된 상태 (PR 받은 두명 중 마지막 사람이 상태 변경)
and removed
확인 요청
리뷰어에게 리뷰 요청 PR 날린 상태 (PR 머지 전)
labels
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 PR 개요
🔍 변경 사항
Dropdown 버튼을 구현했고, 사용처가 2개정도로 파악이 되어서 이런 장소들에 대응될 수 있도록 최대한 범용적으로 구성하였습니다.
✅ 체크리스트 (Checklist)
🏃 Todos
1가지 이슈가 있습니다.
📷 스크린샷 및 동영상 (선택 사항)
2024-11-13.9.45.45.mov
📚 참고 자료 (선택 사항)