-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FE][Feat] #13 #14 : bottomsheet와 bottomsheet 내부 content #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happyhyep
previously approved these changes
Nov 13, 2024
effozen
previously approved these changes
Nov 13, 2024
그냥 이대로 올려도 될 거 같아서 Approve하긴 했는데 시맨틱 태그 부분은 조금 마음에 걸립니다.(접근성 측면, 나중에 생각하기로 했지만 시맨틱 태그 등은 개발단계에서 고려해야 비용이 제일 적다고 생각해서..) 한번 확인해주실 수 있을까요? |
시맨틱 태그를 추가하였고 bottomsheet의 framer-motion을 제거하였습니다. 일부 inline-css로 작성된 코드를 tailwind로 변경하였습니다 |
leedongyull
approved these changes
Nov 13, 2024
effozen
approved these changes
Nov 13, 2024
happyhyep
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 PR 개요
🔍 변경 사항
✅ 체크리스트 (Checklist)
🔄 관련 이슈 (Linked Issues)
📷 스크린샷 및 동영상
2024-11-13.3.49.14.mov
2024-11-13.3.50.03.mov
🧪 테스트 방법