Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fe/#106 add channel UI merge #173

Merged
merged 28 commits into from
Nov 14, 2024

Conversation

leedongyull
Copy link
Collaborator

πŸ“ PR κ°œμš”

AddChannel νŽ˜μ΄μ§€ UI κ΅¬ν˜„ 및 json 머지


πŸ” λ³€κ²½ 사항

UI κ΅¬ν˜„
Figma에 맞게 λ””μžμΈ μˆ˜μ •
tailwind 색상 μΆ”κ°€
Layout 적용


βœ… 체크리슀트 (Checklist)

  • μ½”λ“œκ°€ λΉŒλ“œ 였λ₯˜ 없이 잘 μž‘λ™ν•˜λŠ”μ§€ 확인
  • ν…ŒμŠ€νŠΈκ°€ ν†΅κ³Όν•˜λŠ”μ§€ 확인
  • μŠ€νƒ€μΌ κ°€μ΄λ“œμ™€ 일관성을 μœ μ§€ν–ˆλŠ”μ§€ 확인
  • κ΄€λ ¨ λ¬Έμ„œκ°€ μ—…λ°μ΄νŠΈλ˜μ—ˆλŠ”μ§€ 확인 (선택 사항)
  • 리뷰어가 이해할 수 μžˆλ„λ‘ μ£Όμ„μ΄λ‚˜ μ„€λͺ…을 μΆ”κ°€ν–ˆλŠ”μ§€ 확인

πŸ”„ κ΄€λ ¨ 이슈 (Linked Issues)

#106 μž‘μ—…


πŸ“· μŠ€ν¬λ¦°μƒ· 및 λ™μ˜μƒ (선택 사항)

ViteReactTS-Chrome2024-11-1408-39-33-ezgif com-video-to-gif-converter

ν™”λ©΄ GIF

μ‚¬μš©μž μ‚­μ œ 없어짐

μ‚¬μš©μž 5λͺ… μ΄μƒμΌλ•Œ, μ‚­μ œ λ²„νŠΌ 없어짐

μ‚­μ œ ν…ŒμŠ€νŠΈ

mockData μ΄μš©ν•΄μ„œ ν…ŒμŠ€νŠΈ 3번 μ‚¬μš©μž μ‚­μ œ μ‹œ 4,5번 μ‚¬μš©μžκ°€ 3,4번으둜 당겨짐
swagger λ³΄λ‹ˆ μ‚¬μš©μž ꡬ뢄은 μ΄λ¦„μœΌλ‘œ ν•˜κ³  idλŠ” μ‚¬μš© μ•ˆν•˜λŠ” 것 κ°™μ•„μ„œ 인덱슀 λŒ€μš©μœΌλ‘œ κ΅¬ν˜„ν–ˆμŠ΅λ‹ˆλ‹€!


참고사항

  • 아직 경둜 μ„€μ • μ»΄ν¬λ„ŒνŠΈ κ΅¬ν˜„μ€ λͺ»ν–ˆμŠ΅λ‹ˆλ‹€ (지도 νŽ˜μ΄μ§€μ™€ μ—°λ™ν•΄μ„œ 마컀의 정보λ₯Ό λ°›μ•„ 와야함 + λ°›μ•„ 였면 λ””μžμΈλ„ λ³€κ²½ 돼야함)
  • λ”°λΌμ„œ 아직 ν•˜λ‹¨ Footer λ²„νŠΌμ˜ μƒνƒœ 변화도 κ΅¬ν˜„ν•˜μ§€ μ•Šμ•˜μŠ΅λ‹ˆλ‹€!
  • μΆ”ν›„ 마컀 μ„€μ • κΈ°λŠ₯이 μ™„λ£Œλ˜λ©΄ μΆ”κ°€ν•  μ˜ˆμ •μž…λ‹ˆλ‹€
  • 상단 Header의 κ²½μš°λ„ 아직 λ’€λ‘œκ°€κΈ° λ²„νŠΌμ΄ κ΅¬ν˜„λ˜μ§€ μ•Šμ•„ μ—†λŠ” μƒνƒœμž…λ‹ˆλ‹€
  • μ˜μƒμ€ ν°νŠΈκ°€ μ μš©λ˜μ–΄ μžˆμ§€ μ•Šμ•„ 어색해 보일 수 μžˆμŠ΅λ‹ˆλ‹€!

leedongyull and others added 27 commits November 6, 2024 18:20
@github-actions github-actions bot added the 확인 μš”μ²­ λ¦¬λ·°μ–΄μ—κ²Œ 리뷰 μš”μ²­ PR λ‚ λ¦° μƒνƒœ (PR 머지 μ „) label Nov 14, 2024
@github-actions github-actions bot requested a review from happyhyep November 14, 2024 10:19
@github-actions github-actions bot requested a review from juwon5272 November 14, 2024 10:19
@leedongyull leedongyull merged commit 18ec212 into frontend Nov 14, 2024
2 of 5 checks passed
@leedongyull leedongyull deleted the feature/fe/#106-AddChannelUI-Merge branch November 17, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
확인 μš”μ²­ λ¦¬λ·°μ–΄μ—κ²Œ 리뷰 μš”μ²­ PR λ‚ λ¦° μƒνƒœ (PR 머지 μ „)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants