Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FE][Feat] 로그인 api 연동 #199

Merged
merged 4 commits into from
Nov 19, 2024
Merged

[FE][Feat] 로그인 api 연동 #199

merged 4 commits into from
Nov 19, 2024

Conversation

happyhyep
Copy link
Member

📝 PR 개요

로그인 api 연동

🔍 변경 사항

  • 로그인 dto 추가
  • 로그인 api 연동

✅ 체크리스트 (Checklist)

  • 코드가 빌드 오류 없이 잘 작동하는지 확인
  • 테스트가 통과하는지 확인
  • 스타일 가이드와 일관성을 유지했는지 확인
  • 관련 문서가 업데이트되었는지 확인 (선택 사항)
  • 리뷰어가 이해할 수 있도록 주석이나 설명을 추가했는지 확인

🔄 관련 이슈 (Linked Issues)

#197

@happyhyep happyhyep added the 확인 요청 리뷰어에게 리뷰 요청 PR 날린 상태 (PR 머지 전) label Nov 18, 2024
@happyhyep happyhyep self-assigned this Nov 18, 2024
@happyhyep happyhyep linked an issue Nov 18, 2024 that may be closed by this pull request
로그인 api 연동 #197
Closed
leedongyull
leedongyull approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@leedongyull leedongyull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juwon5272
Copy link
Collaborator

package.json은 추가된 것만 추가 되는게 아니라 어떨때 다시 써지는지 모르겠네요

@happyhyep happyhyep merged commit 3d77902 into frontend Nov 19, 2024
4 of 7 checks passed
@effozen effozen deleted the feature/fe/#197-doLogin branch December 5, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juwon5272 juwon5272 juwon5272 approved these changes

@leedongyull leedongyull leedongyull approved these changes

Assignees

@happyhyep happyhyep

Labels
확인 요청 리뷰어에게 리뷰 요청 PR 날린 상태 (PR 머지 전)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

로그인 api 연동
3 participants
@happyhyep @juwon5272 @leedongyull