[FE][Feat] #204 : 캔버스 내 마커 추가 및 삭제 기능 구현 #207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pwm-2024/web28-DDara into feature/fe/#204-addMarker
…ampwm-2024/web28-DDara into feature/fe/#204-addMarker
…ampwm-2024/web28-DDara into feature/fe/#204-addMarker
crongro
reviewed
Nov 19, 2024
| const scaleRef = useRef(STEP_SCALES[7]); | ||
| const viewPosRef = useRef(INITIAL_POSITION); | ||
| const [iconImage, setIconImage] = useState<HTMLImageElement | null>(null); | ||
| const [markerPoint, setMarkerPoint] = useState<IPoint | null>(props.point); |
There was a problem hiding this comment.
point가 props에도 있고 여기에도 있고 차이점이 좀 헷갈릴듯.
| } | ||
| }, [markerPoint, iconImage]); | ||
|
|
||
| return { mark, scaleRef, viewPosRef }; |
There was a problem hiding this comment.
근데 이름에 point, mark 뭔지는 알겠으나 더 구체적인 이름으로하면 더 좋을듯.
| } | ||
|
|
||
| const INITIAL_POSITION = { x: 0, y: 0 }; | ||
| const STEP_SCALES = [100, 50, 30, 20, 10, 5, 3, 1, 0.5, 0.3, 0.1, 0.05, 0.03, 0.02, 0.01, 0.005]; |
There was a problem hiding this comment.
이건 공통상수로 정의해서 같이 사용해도 될듯. 다른 파일에도 보여서.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 변경 사항
✅ 체크리스트 (Checklist)
🔄 관련 이슈 (Linked Issues)
#204
📷 스크린샷 및 동영상 (선택 사항)
default.mp4