Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FE][Chore] #234 : 페이지 초기 세팅 #235

Merged
merged 2 commits into from
Nov 21, 2024
Merged

[FE][Chore] #234 : 페이지 초기 세팅 #235

merged 2 commits into from
Nov 21, 2024

Conversation

happyhyep
Copy link
Member

name: PR 템플릿
about: PR 날릴 때 사용하시면 됩니다.
title: ''
labels: ''
assignees: ''

📝 PR 개요

페이지 초기 세팅

🔍 변경 사항

  • 파비콘 다운 및 적용
  • html 타이틀 적용

✅ 체크리스트 (Checklist)

  • 코드가 빌드 오류 없이 잘 작동하는지 확인
  • 테스트가 통과하는지 확인
  • 스타일 가이드와 일관성을 유지했는지 확인
  • 관련 문서가 업데이트되었는지 확인 (선택 사항)
  • 리뷰어가 이해할 수 있도록 주석이나 설명을 추가했는지 확인

🔄 관련 이슈 (Linked Issues)

#234

📷 스크린샷 및 동영상 (선택 사항)

  • 변경 전
    image

  • 변경 후
    image

@happyhyep happyhyep added the 확인 요청 리뷰어에게 리뷰 요청 PR 날린 상태 (PR 머지 전) label Nov 21, 2024
@happyhyep happyhyep self-assigned this Nov 21, 2024
@happyhyep happyhyep linked an issue Nov 21, 2024 that may be closed by this pull request
페이지 초기 세팅 (파비콘 및 html title 등) #234
Closed
effozen
effozen approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@effozen effozen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@happyhyep happyhyep merged commit 5527c2b into frontend Nov 21, 2024
3 of 4 checks passed
@effozen effozen deleted the feature/fe/#234-settingHTML branch December 5, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@effozen effozen effozen approved these changes

@juwon5272 juwon5272 juwon5272 approved these changes

Assignees

@happyhyep happyhyep

Labels
확인 요청 리뷰어에게 리뷰 요청 PR 날린 상태 (PR 머지 전)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

페이지 초기 세팅 (파비콘 및 html title 등)
3 participants
@happyhyep @juwon5272 @effozen