-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FE][Feat] #106 : add-channel 페이지 사용자 별 경로 설정 기능 구현 및 header 상수화 #237
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
📝 PR 개요
✅ 체크리스트 (Checklist)
🔄 관련 이슈 (Linked Issues)
#106
📷 스크린샷 및 동영상 (선택 사항)
📚 생겼던 이슈
Header 상수화 과정에서 동적 파라미터 받기
이런식으로 구현해서 사용하려고 하였음. 하지만 title 만 로직이 복잡해지고 심지어 해시값으로 나와서 사용할 수 없었음
따라서 현재는 임시로 이런식으로 사용...
Footer 상수화
검색 기능 및 주소 매핑 (ex. 서울특별시 강남구 강남대로 지하396 -> 강남역) 은 추후 추가 예정