[FE][Refactor] #224 : CanvasWithMap 이벤트 함수를 훅으로 분리 #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 코드 가독성 개선 - 에러 케이스 추가 - 타입 분리
- 함수를 분리했다.
happyhyep
previously approved these changes
Nov 23, 2024
effozen
dismissed stale reviews from leedongyull and happyhyep
The merge-base changed after approval.
effozen
dismissed stale reviews from leedongyull and happyhyep
The merge-base changed after approval.
happyhyep
previously approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 PR 개요
CanvasWIthMap을 이벤트 함수를 훅으로 분리
🔍 변경 사항
CanvasWithMap에 있는 이벤트 함수 로직을 훅으로 분리했다.
✅ 체크리스트 (Checklist)
🔄 관련 이슈 (Linked Issues)
#224
⚙️ 기타 추가사항
2024-11-23.5.03.17.mov
분리는 성공하였으나, 위와 같이 오동작하는 문제가 있음.