Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FE][Feat] #112 : 통신 로직 및 받아온 데이터 드랍다운에 반영 #261

Merged
merged 3 commits into from
Nov 25, 2024
Merged

[FE][Feat] #112 : 통신 로직 및 받아온 데이터 드랍다운에 반영 #261

merged 3 commits into from
Nov 25, 2024

Conversation

effozen
Copy link
Collaborator

@effozen effozen commented Nov 25, 2024

📝 PR 개요

통신 로직 및 받아온 데이터 드랍다운에 반영

🔍 변경 사항

  • API에서 res.data로 수정
  • API로 받아온 정보를 바탕으로 드랍다운과 화면에 보여지도록 출력
  • channel uuid 별로 다른 정보를 가져오게 수정

✅ 체크리스트 (Checklist)

  • 코드가 빌드 오류 없이 잘 작동하는지 확인
  • 테스트가 통과하는지 확인
  • 스타일 가이드와 일관성을 유지했는지 확인
  • 관련 문서가 업데이트되었는지 확인 (선택 사항)
  • 리뷰어가 이해할 수 있도록 주석이나 설명을 추가했는지 확인

🔄 관련 이슈 (Linked Issues)

#112

📷 스크린샷 및 동영상 (선택 사항)

2024-11-25.7.36.11.mov

@github-actions github-actions bot added the 확인 요청 리뷰어에게 리뷰 요청 PR 날린 상태 (PR 머지 전) label Nov 25, 2024
@effozen effozen requested review from leedongyull and removed request for juwon5272 November 25, 2024 10:37
happyhyep
happyhyep approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@happyhyep happyhyep left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니닷!!

@happyhyep
Copy link
Member

@juwon5272 님 슬랙에 남겼는데, 이 코드 PR 받고 api 호출 다시 한번 해보시겠어요?

leedongyull
leedongyull approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@leedongyull leedongyull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@effozen effozen merged commit d41adbe into frontend Nov 25, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happyhyep happyhyep happyhyep approved these changes

@leedongyull leedongyull leedongyull approved these changes

Assignees

@effozen effozen

Labels
확인 요청 리뷰어에게 리뷰 요청 PR 날린 상태 (PR 머지 전)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@effozen @happyhyep @leedongyull