Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FE][Feat] #280 : GuestView 구현 #281

Closed
wants to merge 6 commits into from
Closed

[FE][Feat] #280 : GuestView 구현 #281

wants to merge 6 commits into from

Conversation

effozen
Copy link
Collaborator

@effozen effozen commented Nov 26, 2024

📝 PR 개요

GuestView 구현

🔍 변경 사항

  • GuestView 구현

✅ 체크리스트 (Checklist)

  • 코드가 빌드 오류 없이 잘 작동하는지 확인
  • 테스트가 통과하는지 확인
  • 스타일 가이드와 일관성을 유지했는지 확인
  • 관련 문서가 업데이트되었는지 확인 (선택 사항)
  • 리뷰어가 이해할 수 있도록 주석이나 설명을 추가했는지 확인

🔄 관련 이슈 (Linked Issues)

#280

📷 스크린샷 및 동영상 (선택 사항)

스크린샷 2024-11-26 오후 7 01 09

@effozen effozen self-assigned this Nov 26, 2024
@effozen effozen added the 확인 요청 리뷰어에게 리뷰 요청 PR 날린 상태 (PR 머지 전) label Nov 26, 2024
happyhyep
happyhyep requested changes Nov 26, 2024
View reviewed changes
Copy link
Member

@happyhyep happyhyep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GuestView 특징 때문에 '현재 내 위치'라는 텍스트가 아니라, 플로팅버튼처럼 출발지, 도착지로 텍스트 표현 부탁드립니다!
각각 출발지/도착지 마커 svg 이미지 옆에 텍스트 넣어주시면 될 것 같아요!

@effozen effozen closed this Nov 26, 2024
@effozen effozen deleted the feature/fe/#280-guestView branch December 5, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happyhyep happyhyep happyhyep requested changes

@juwon5272 juwon5272 juwon5272 approved these changes

Assignees

@effozen effozen

Labels
확인 요청 리뷰어에게 리뷰 요청 PR 날린 상태 (PR 머지 전)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@effozen @juwon5272 @happyhyep