Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE][Chore] volumes로 app 디렉토리 공유하도록 변경 #284

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

happyhyep
Copy link
Member

@happyhyep happyhyep commented Nov 26, 2024

📝 PR 개요

volumes로 app 디렉토리 공유하여 배포 문제 해결


🔍 변경 사항

  • volumes로 app 디렉토리 공유하도록 변경
  • node_modules는 충돌 때문에 volumes에서 제외
  • frontend 컨테이너 backend에 의존

✅ 체크리스트 (Checklist)

  • 코드가 빌드 오류 없이 잘 작동하는지 확인
  • 테스트가 통과하는지 확인
  • 스타일 가이드와 일관성을 유지했는지 확인
  • 관련 문서가 업데이트되었는지 확인 (선택 사항)
  • 리뷰어가 이해할 수 있도록 주석이나 설명을 추가했는지 확인

- FE 컨테이너 Workdir 생성 안되는 문제 해결
- BE express 참조 문제 해결
@happyhyep happyhyep added the 확인 요청 리뷰어에게 리뷰 요청 PR 날린 상태 (PR 머지 전) label Nov 26, 2024
@happyhyep happyhyep self-assigned this Nov 26, 2024
@happyhyep happyhyep changed the title [BE][Chore] FE 컨테이너 Workdir 생성 안되는 문제 해결 [BE][Chore] volumes로 app 디렉토리 공유하도록 변경 Nov 26, 2024
@happyhyep happyhyep requested a review from juwon5272 November 26, 2024 11:00
Copy link
Collaborator

@leedongyull leedongyull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@effozen effozen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@happyhyep happyhyep merged commit 3b4b5e3 into development Nov 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
확인 요청 리뷰어에게 리뷰 요청 PR 날린 상태 (PR 머지 전)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants