Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FE][Feature] #280 : HostView, GuestView 구현 및 업데이트 #288

Merged
merged 8 commits into from
Nov 27, 2024
Merged

[FE][Feature] #280 : HostView, GuestView 구현 및 업데이트 #288

merged 8 commits into from
Nov 27, 2024

Conversation

effozen
Copy link
Collaborator

@effozen effozen commented Nov 26, 2024

📝 PR 개요

HostView, GuestView 구현 및 업데이트

🔍 변경 사항

  • GuestView 구현
  • HostView 구현
  • 우측하단 가이드 구현
  • 드랍다운 상태 구현

✅ 체크리스트 (Checklist)

  • 코드가 빌드 오류 없이 잘 작동하는지 확인
  • 테스트가 통과하는지 확인
  • 스타일 가이드와 일관성을 유지했는지 확인
  • 관련 문서가 업데이트되었는지 확인 (선택 사항)
  • 리뷰어가 이해할 수 있도록 주석이나 설명을 추가했는지 확인

🔄 관련 이슈 (Linked Issues)

#280

📷 스크린샷 및 동영상 (선택 사항)

2024-11-27.1.05.35.mov

@effozen effozen requested a review from happyhyep November 26, 2024 16:09
@effozen effozen self-assigned this Nov 26, 2024
@effozen effozen requested a review from juwon5272 November 26, 2024 16:09
@effozen effozen added the 확인 요청 리뷰어에게 리뷰 요청 PR 날린 상태 (PR 머지 전) label Nov 26, 2024
leedongyull
leedongyull approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@leedongyull leedongyull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

happyhyep
happyhyep approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@happyhyep happyhyep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!! 오늘까지 하기로 한 작업 다음 PR에서 날려주세요!!

frontend/src/component/IconGuide/GuestMarker.tsx Show resolved Hide resolved
frontend/src/pages/HostView.tsx Show resolved Hide resolved
@happyhyep happyhyep merged commit 1a4df9f into frontend Nov 27, 2024
2 of 3 checks passed
@effozen effozen deleted the feature/fe/#280-guestView-updated branch December 5, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happyhyep happyhyep happyhyep approved these changes

@leedongyull leedongyull leedongyull approved these changes

@juwon5272 juwon5272 Awaiting requested review from juwon5272

Assignees

@effozen effozen

Labels
확인 요청 리뷰어에게 리뷰 요청 PR 날린 상태 (PR 머지 전)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@effozen @leedongyull @happyhyep