Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE][Feat] #370 : 마커 아이콘 수정 #371

Merged
merged 38 commits into from
Dec 3, 2024

Conversation

effozen
Copy link
Collaborator

@effozen effozen commented Dec 3, 2024

📝 PR 개요

마커 아이콘 수정

🔍 변경 사항

마커 아이콘 채워진 걸로 변경

✅ 체크리스트 (Checklist)

  • 코드가 빌드 오류 없이 잘 작동하는지 확인
  • 테스트가 통과하는지 확인
  • 스타일 가이드와 일관성을 유지했는지 확인
  • 관련 문서가 업데이트되었는지 확인 (선택 사항)
  • 리뷰어가 이해할 수 있도록 주석이나 설명을 추가했는지 확인

🔄 관련 이슈 (Linked Issues)

#370

📷 스크린샷 및 동영상 (선택 사항)

스크린샷 2024-12-03 오후 1 54 35

@github-actions github-actions bot added the 확인 요청 리뷰어에게 리뷰 요청 PR 날린 상태 (PR 머지 전) label Dec 3, 2024
juwon5272
juwon5272 previously approved these changes Dec 3, 2024
happyhyep
happyhyep previously approved these changes Dec 3, 2024
Copy link
Member

@happyhyep happyhyep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확실히 채워진 이미지가 훨씬 낫네요!! ㅎㅎ 감사합니다!!

@effozen effozen dismissed stale reviews from happyhyep and juwon5272 December 3, 2024 08:30

The merge-base changed after approval.

@effozen effozen dismissed juwon5272’s stale review December 3, 2024 08:41

The merge-base changed after approval.

juwon5272
juwon5272 previously approved these changes Dec 3, 2024
juwon5272
juwon5272 previously approved these changes Dec 3, 2024
@effozen effozen dismissed juwon5272’s stale review December 3, 2024 08:47

The merge-base changed after approval.

happyhyep
happyhyep previously approved these changes Dec 3, 2024
@effozen effozen dismissed happyhyep’s stale review December 3, 2024 08:55

The merge-base changed after approval.

juwon5272
juwon5272 previously approved these changes Dec 3, 2024
@effozen effozen dismissed juwon5272’s stale review December 3, 2024 12:42

The merge-base changed after approval.

juwon5272
juwon5272 previously approved these changes Dec 3, 2024
happyhyep
happyhyep previously approved these changes Dec 3, 2024
@effozen effozen dismissed stale reviews from happyhyep and juwon5272 December 3, 2024 12:49

The merge-base changed after approval.

@effozen effozen merged commit 9b604eb into frontend Dec 3, 2024
11 checks passed
@effozen effozen deleted the feature/fe/#370-marker-icon-change branch December 5, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
확인 요청 리뷰어에게 리뷰 요청 PR 날린 상태 (PR 머지 전)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants