Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE][Fix] #372 : 바텀시트에서 드랍다운 클릭 시 각각이 따로따로 동작하는 문제 수정 #373

Merged
merged 39 commits into from
Dec 3, 2024

Conversation

effozen
Copy link
Collaborator

@effozen effozen commented Dec 3, 2024

📝 PR 개요

바텀시트에서 드랍다운 클릭 시 각각이 따로따로 동작하는 문제 수정

🔍 변경 사항

전역 상태에 UUID 기반한 아이디 부여. 그리고 그 아이디를 비교해서, 열려있는 게 있는 지 파악해서 동작할 수 있도록 수정

✅ 체크리스트 (Checklist)

  • 코드가 빌드 오류 없이 잘 작동하는지 확인
  • 테스트가 통과하는지 확인
  • 스타일 가이드와 일관성을 유지했는지 확인
  • 관련 문서가 업데이트되었는지 확인 (선택 사항)
  • 리뷰어가 이해할 수 있도록 주석이나 설명을 추가했는지 확인

🔄 관련 이슈 (Linked Issues)

#372

📷 스크린샷 및 동영상 (선택 사항)

2024-12-03.5.27.23.mov

@github-actions github-actions bot added the 확인 요청 리뷰어에게 리뷰 요청 PR 날린 상태 (PR 머지 전) label Dec 3, 2024
leedongyull
leedongyull previously approved these changes Dec 3, 2024
@effozen effozen dismissed leedongyull’s stale review December 3, 2024 08:38

The merge-base changed after approval.

leedongyull
leedongyull previously approved these changes Dec 3, 2024
@effozen effozen dismissed leedongyull’s stale review December 3, 2024 11:10

The merge-base changed after approval.

happyhyep
happyhyep previously approved these changes Dec 3, 2024
Copy link
Member

@happyhyep happyhyep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!! 그런데 아마 그 전 머지된 것도 포함된 것 같아서 변경된 내용이 바텀시트 뿐이 아닌 것 같아서, 혹시 머지하시고나서 충돌난 거 없는지, 기능 덮여서 적용된 거 없는지 확인 한번만 부탁드릴게요!!

@effozen effozen dismissed happyhyep’s stale review December 3, 2024 11:20

The merge-base changed after approval.

@juwon5272 juwon5272 self-requested a review December 3, 2024 12:24
juwon5272
juwon5272 previously approved these changes Dec 3, 2024
@effozen effozen dismissed juwon5272’s stale review December 3, 2024 12:24

The merge-base changed after approval.

happyhyep
happyhyep previously approved these changes Dec 3, 2024
@effozen effozen dismissed happyhyep’s stale review December 3, 2024 12:44

The merge-base changed after approval.

@effozen effozen removed the request for review from leedongyull December 3, 2024 12:53
@effozen effozen merged commit 36321f2 into frontend Dec 3, 2024
7 checks passed
@effozen effozen deleted the feature/fe/#372-bottomsheet-dropdown-error branch December 5, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
확인 요청 리뷰어에게 리뷰 요청 PR 날린 상태 (PR 머지 전)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants