회원 탈퇴를 할 수 있다. #545
Merged
회원 탈퇴를 할 수 있다. #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dltmd202
reviewed
Dec 9, 2023
| @@ -7,7 +7,7 @@ export class UsersRoleEntity { | |||
| @PrimaryColumn({ type: 'bigint', nullable: false }) | |||
| userId: number; | |||
|
|
|||
| @ManyToOne(() => UserEntity) | |||
| @ManyToOne(() => UserEntity, { onDelete: 'CASCADE' }) | |||
There was a problem hiding this comment.
아하! 일단은 이렇게 해서 삭제가 되었나 보네요! 다행입니다.
Comment on lines
+43
to
+46
| @OneToOne(() => GroupAchievementEntity, { | ||
| nullable: true, | ||
| onDelete: 'SET NULL', | ||
| }) |
There was a problem hiding this comment.
그룹 달성기록은 casecade에서 삭제 안하고 나두셨네요! 좋습니다!
| @@ -17,7 +17,7 @@ export class UserGroupEntity extends BaseTimeEntity { | |||
| @PrimaryGeneratedColumn() | |||
| id: number; | |||
|
|
|||
| @ManyToOne(() => UserEntity) | |||
| @ManyToOne(() => UserEntity, { onDelete: 'CASCADE' }) | |||
There was a problem hiding this comment.
이게 어떻게 될지 모르겠는데!
혹시 그룹장이 회원탈퇴를 하면 어떻게 될까요??
There was a problem hiding this comment.
우선은 group entity는 삭제 안되고 user_group만 삭제 그러니까 그룹장만 그룹에서 없어지도록 했습니다.
Manager가 있으면 그 Manager가 그룹장이 된다거나 이런 로직은 현재 논의된게 없고 케이스가 복잡해서 우선은 그룹장만 나가도록 해놨습니다.
There was a problem hiding this comment.
아하!... 그죠 그건 너무 복잡해질 것 같긴해요...
네 일단 너무 수고 하셨어요!
Dltmd202
approved these changes
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 요약
변경 사항
Linked Issue
close #536