Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tsconfig.json #1467

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

ironspec07
Copy link

@ironspec07 ironspec07 commented Oct 11, 2023

Description

Added sourceMap: true to the tsconfig.json of the new project which allows users to debug from VSCode easily by pressing F5

Changes

Added "sourceMap" : true to tsconfig.json

Checks

  • Project Builds
  • Project passes tests and checks
  • Updated documentation accordingly

@what-the-diff
Copy link

what-the-diff bot commented Oct 11, 2023

PR Summary

  • Inclusion of Source Map
    The configuration file for our TypeScript project was updated to generate source maps. This allows us to trace back any errors or bugs to the original source code, enhancing the debugging process and overall maintainability of the project.

@ghost
Copy link

ghost commented Oct 11, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Member

@NickSeagull NickSeagull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is meant to be added to the project template not the Booster tsconfig 😅

@ironspec07
Copy link
Author

Sorry 😅, I am kinda new to open source contributions.

@ironspec07
Copy link
Author

Thanks for the suggestion. @NickSeagull

Copy link
Member

@NickSeagull NickSeagull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Let's see if the tests pass! 👏

@NickSeagull
Copy link
Member

/integration sha=8b29da3

@github-actions
Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

@github-actions
Copy link
Contributor

❌ Oh no! Integration tests have failed

@NickSeagull
Copy link
Member

Hey @ironspec07 can you edit the integration test at packages/framework-integration-tests/integration/provider-unaware/cli/cli.project.integration.ts:358:15 so it checks for the existence of the sourceMap field?

It is failing in the integration tests: https://github.com/boostercloud/booster/actions/runs/6497419214/job/17646575081#step:3:720

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants