Skip to content

Use handshake_timeout for closing handshake during read operations #3000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ashtum
Copy link
Collaborator

@ashtum ashtum commented Apr 13, 2025

Fixes #2999

@ashtum ashtum force-pushed the use-handshake_timeout-inside-async_read_some branch from 85a4966 to 77fb244 Compare April 13, 2025 13:10
Copy link

codecov bot commented Apr 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.13%. Comparing base (1d8dfae) to head (ec20603).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3000   +/-   ##
========================================
  Coverage    93.13%   93.13%           
========================================
  Files          177      177           
  Lines        13655    13656    +1     
========================================
+ Hits         12717    12718    +1     
  Misses         938      938           
Files with missing lines Coverage Δ
include/boost/beast/websocket/impl/read.hpp 95.29% <100.00%> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d8dfae...ec20603. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ashtum ashtum force-pushed the use-handshake_timeout-inside-async_read_some branch 27 times, most recently from 36d8c1e to 2c0a402 Compare April 26, 2025 07:52
@ashtum ashtum force-pushed the use-handshake_timeout-inside-async_read_some branch 12 times, most recently from 87f0415 to 92f33ba Compare April 26, 2025 14:29
@ashtum ashtum force-pushed the use-handshake_timeout-inside-async_read_some branch from 92f33ba to ec20603 Compare April 26, 2025 16:00
@ashtum ashtum merged commit c5d20f5 into boostorg:develop Apr 26, 2025
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

async_read occasionally doesn't abort when data is sent after close in WebSocket stream
1 participant