Avoid fallback routine buffer overruns #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mborland
force-pushed
the
from_chars_failures
branch
from
c6c9086
to
78cd508
Compare
|
@pdimov I bumped up the statically allocated array size form 256 to 1024, and added handling for a dynamic array using |
pdimov
reviewed
May 22, 2023
pdimov
reviewed
May 22, 2023
pdimov
reviewed
May 22, 2023
|
You should merge/rebase the |
The force push was a rebase onto develop so I have it, and there are no new failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #45
std::strtoddoes not accept a size argument so when parsing a buffer with valid contents pastlastthe results would be incorrect. Locally ran the benchmarks from #44 that caused the linked issue, and they are resolved.