Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify push_back logic #71

Merged
merged 2 commits into from
Dec 28, 2024
Merged

simplify push_back logic #71

merged 2 commits into from
Dec 28, 2024

Conversation

unixnme
Copy link
Contributor

@unixnme unixnme commented Jul 5, 2022

Hello boost devs/maintainers,

I find the current push_back logic a bit strange with the two-steps

  • call resize() method but using the default value = false
  • then call set() method to explicitly set the bit

I feel it would make sense to simplify this with a single step and reduce overhead

  • call resize() method with the given bit

I'm not sure if this is intended, but if not, here is my pull request to address the issue.

Thanks.

@jeking3 jeking3 self-assigned this Nov 26, 2024
@jeking3
Copy link
Collaborator

jeking3 commented Nov 26, 2024

Please rebase this on the current develop branch so that we can run the full set of tests against it. Thanks.

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.53%. Comparing base (d4be7a4) to head (237dafa).
Report is 22 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #71      +/-   ##
===========================================
- Coverage    95.80%   95.53%   -0.28%     
===========================================
  Files            5        5              
  Lines          668      672       +4     
  Branches         0      210     +210     
===========================================
+ Hits           640      642       +2     
- Misses          28       29       +1     
- Partials         0        1       +1     
Files with missing lines Coverage Δ
include/boost/dynamic_bitset/dynamic_bitset.hpp 95.19% <100.00%> (-0.30%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd59d32...237dafa. Read the comment docs.

@jeking3 jeking3 merged commit b96250c into boostorg:develop Dec 28, 2024
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants