-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix use of intrinsics on windows ARM platforms #928
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #928 +/- ##
========================================
Coverage 92.95% 92.95%
========================================
Files 85 85
Lines 8047 8047
========================================
Hits 7480 7480
Misses 567 567
Continue to review full report in Codecov by Sentry.
|
|
|
I feel like rather than doing |
There is overlap in the 64-bit platforms with |
Nah, let's merge it as-is. I'm expecting to remove it with dependency on Boost.Charconv soon anyway. |
Closes: #926
Closes: #927
Changes use of intrinsics: https://learn.microsoft.com/en-us/cpp/intrinsics/umul128?view=msvc-170 and https://learn.microsoft.com/en-us/cpp/intrinsics/emul-emulu?view=msvc-170