only solve problems if have enough precision #1004
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is chunk 3 for #1000
In the
ibeta_inverse.hpp
file, there exists root-finding problems of the form:This function has an extrema at 1 / (1 + a).
Newton solver finds dubious roots
For extreme values of a, the extrema evaluates to 0 or 1 due to floating point limitations. For these cases, the objectives function evaluation always has the same sign, and is never zero. The Newton solver finds a root for the reasons described in #1005.
This PR
if (cross == 0 || cross == 1) { return cross; }
to return early for values that lack the numerical precision to construct a meaningful objective functionBOOST_MATH_ASSERT
to prevent the construction of root finding problems that are problematic.