Improve test coverage. #1069

jzmaddock · 2024-01-21T16:58:35Z

Try and get all the special_functions/a*.hpp files up to 100%.

jzmaddock · 2024-01-21T16:59:22Z

Refs #1068

codecov · 2024-01-21T17:55:21Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e06b1b7) 85.24% compared to head (045a87e) 88.32%.
Report is 3 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1069      +/-   ##
===========================================
+ Coverage    85.24%   88.32%   +3.07%     
===========================================
  Files          875      762     -113     
  Lines        66568    64394    -2174     
===========================================
+ Hits         56745    56875     +130     
+ Misses        9823     7519    -2304

Files	Coverage Δ
include/boost/math/special_functions/acosh.hpp	`100.00% <100.00%> (+10.00%)`	⬆️
include/boost/math/special_functions/airy.hpp	`100.00% <ø> (+1.40%)`	⬆️
include/boost/math/special_functions/asinh.hpp	`100.00% <100.00%> (+8.69%)`	⬆️
include/boost/math/special_functions/atanh.hpp	`100.00% <100.00%> (+13.79%)`	⬆️
include/boost/math/special_functions/bernoulli.hpp	`100.00% <ø> (+13.33%)`	⬆️
include/boost/math/special_functions/bessel.hpp	`100.00% <100.00%> (+16.66%)`	⬆️
...lude/boost/math/special_functions/bessel_prime.hpp	`98.92% <100.00%> (+14.61%)`	⬆️
include/boost/math/special_functions/beta.hpp	`96.10% <ø> (+21.29%)`	⬆️
.../boost/math/special_functions/detail/bessel_i0.hpp	`84.61% <ø> (+71.51%)`	⬆️
test/acosh_test.hpp	`72.50% <100.00%> (+3.05%)`	⬆️
... and 14 more

... and 203 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e06b1b7...045a87e. Read the comment docs.

Remove I0 initializers and rely on C++11 thread safe static const initialization.

And don't try and run concept checks with test coverage collection.

Add some more tests for the code that can be reached.

Also fixes a bug in bessel_y_derivative_small_z_series corner case.

Improve overflow handling in the implementations themselves.

…pes.

Kill some unused variable warnings. Mark up code we think is unreachable but aren't sure about.

ckormanyos · 2024-02-09T19:36:53Z

Dude it's massive +3 persent in one swath!

Fixed Conflicts: test/Jamfile.v2 test/condition_number_test.cpp

jzmaddock · 2024-02-10T15:41:48Z

OK folks, I hope this tranche of coverage improvement is good to go, I'll start a fresh PR for any more before the changes here get out of hand. @NAThompson there are a couple of drone failures in random_search_test which appear unrelated - tolerance too tight, or something non-deterministic in there?

NAThompson · 2024-02-10T16:20:31Z

@jzmaddock : I noticed that yesterday and provided what I hoped was a fix; looks like I didn't quite get it.

I recommend merging over the failure and I'll hopefully figure this one out pretty quick . . .

ckormanyos · 2024-02-10T16:48:30Z

merging over the failure and I'll hopefully figure this one out pretty quick . . .

done. merged. Thank you John.

ckormanyos · 2024-02-10T16:49:06Z

Ughhhh wait a minute. I just merged your branch. Not mine.

ckormanyos · 2024-02-10T16:49:45Z

I guess I need to revert that commit? I hope I did not turn this into a mess.

jzmaddock · 2024-02-10T16:50:34Z

Ughhhh wait a minute. I just merged your branch. Not mine.

Should be OK ;)

I recommend merging over the failure and I'll hopefully figure this one out pretty quick . . .

OK lets see what happens on develop

jzmaddock · 2024-02-10T16:51:34Z

I guess I need to revert that commit? I hope I did not turn this into a mess.

Should be OK unless someone notices any SNAFU's.

ckormanyos · 2024-02-10T16:51:53Z

Indeed. I would just end up fumbling the fumble. I will merge my dos to develop.

Then we just have the remaining very few test failures.

ckormanyos · 2024-02-10T18:15:38Z

Should be OK unless someone notices any SNAFU's.

Thanky you John! Probably, with your expert help (as usual) we can dig out of this.

OK, so finally, I merged the new docs. This contains all your new coverage stuff. The docs look good, but the very few test failures are still present.

ckormanyos · 2024-02-11T12:12:25Z

Should be OK

Thanky you John!

As far as I can tell, everything is now OK on develop. @NAThompson triggered a few runs in his new work in #1083, and drone, GHA are OK there. Thanks again @jzmaddock, and sorry about the back-and-forth.

Improve test coverage.

9e18943

Try and get all the special_functions/a*.hpp files up to 100%.

jzmaddock added 23 commits January 22, 2024 13:23

Improve bernoulli and bessel coverage.

7431f81

Correct bessel_J test case.

bc97599

increase tolerance

1bf4096

Begin improving ibeta coverage.

27b3f9e

Correct sign of cyl_neumann(0,0) result in multiprecision case.

36496d4

More Bessel function coverage.

317b7a6

Remove I0 initializers and rely on C++11 thread safe static const initialization.

Correct typo.

c046f71

Refactor test coverage to put concept checks in their own group.

045a87e

And don't try and run concept checks with test coverage collection.

Continue improving Bessel coverage and removing dead code.

7977144

Correct assert usage.

14eee37

Remove some impossible to reach bessel_jn code.

b30b637

Add some more tests for the code that can be reached.

Improve Bessel Y coverage.

d0bade9

Merge branch 'develop' into improve_coverage

e1033c9

Improve Bessel Y derivative coverage.

60134c0

Also fixes a bug in bessel_y_derivative_small_z_series corner case.

Correct assertion usage.

2adbc21

Improve Bessel K and Y prime coverage.

d6ec06d

Improve overflow handling in the implementations themselves.

Correct concept failures.

b8ea324

Correct test cases.

098676d

Correct test cases.

e285ef3

Merge branch 'develop' into improve_coverage

26e21c9

Correct gauss and gauss_kronrod integrators with strange-precision ty…

1d1a52c

…pes.

Make bessel_k_prime integer order aware.

eef497e

More bessel function tests for improved coverage.

851c171

Kill some unused variable warnings. Mark up code we think is unreachable but aren't sure about.

jzmaddock added 3 commits February 10, 2024 09:27

Add missing using statement.

da7a945

Merge branch 'develop' into improve_coverage

319a521

Fixed Conflicts: test/Jamfile.v2 test/condition_number_test.cpp

Add better bessel_iterator tests.

48b2491

jzmaddock added 2 commits February 10, 2024 10:42

Correct variable name.

bdcecaa

Correct bad merge of condition_number_test (again).

84b1208

ckormanyos merged commit b421431 into develop Feb 10, 2024
67 of 68 checks passed

NAThompson deleted the improve_coverage branch February 10, 2024 17:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve test coverage. #1069

Improve test coverage. #1069

jzmaddock commented Jan 21, 2024

jzmaddock commented Jan 21, 2024

codecov bot commented Jan 21, 2024 •

edited

Loading

ckormanyos commented Feb 9, 2024

jzmaddock commented Feb 10, 2024

NAThompson commented Feb 10, 2024 •

edited

Loading

ckormanyos commented Feb 10, 2024

ckormanyos commented Feb 10, 2024

ckormanyos commented Feb 10, 2024

jzmaddock commented Feb 10, 2024

jzmaddock commented Feb 10, 2024

ckormanyos commented Feb 10, 2024

ckormanyos commented Feb 10, 2024

ckormanyos commented Feb 11, 2024

Improve test coverage. #1069

Improve test coverage. #1069

Conversation

jzmaddock commented Jan 21, 2024

jzmaddock commented Jan 21, 2024

codecov bot commented Jan 21, 2024 • edited Loading

Codecov Report

ckormanyos commented Feb 9, 2024

jzmaddock commented Feb 10, 2024

NAThompson commented Feb 10, 2024 • edited Loading

ckormanyos commented Feb 10, 2024

ckormanyos commented Feb 10, 2024

ckormanyos commented Feb 10, 2024

jzmaddock commented Feb 10, 2024

jzmaddock commented Feb 10, 2024

ckormanyos commented Feb 10, 2024

ckormanyos commented Feb 10, 2024

ckormanyos commented Feb 11, 2024

codecov bot commented Jan 21, 2024 •

edited

Loading

NAThompson commented Feb 10, 2024 •

edited

Loading