-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metadata is now implemented as a single std::vector #466
Merged
anarthal
merged 19 commits into
develop
from
feature/461-optimization-metadata-std-string
Apr 5, 2025
Merged
metadata is now implemented as a single std::vector #466
anarthal
merged 19 commits into
develop
from
feature/461-optimization-metadata-std-string
Apr 5, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #466 +/- ##
========================================
Coverage 99.02% 99.02%
========================================
Files 142 142
Lines 7262 7280 +18
========================================
+ Hits 7191 7209 +18
Misses 71 71
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of several separate std::string objects, metadata now uses a single std::vector and offsets, which is more efficient
Default-constructing metadata objects now leaves all fields in a well-defined state
Added unit tests for metadata
close #461
close #465
close #164