Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metadata is now implemented as a single std::vector #466

Merged
merged 19 commits into from
Apr 5, 2025

Conversation

anarthal
Copy link
Collaborator

@anarthal anarthal commented Apr 4, 2025

Instead of several separate std::string objects, metadata now uses a single std::vector and offsets, which is more efficient
Default-constructing metadata objects now leaves all fields in a well-defined state
Added unit tests for metadata

close #461
close #465
close #164

Copy link

codecov bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.02%. Comparing base (303b9f0) to head (8f45ade).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #466   +/-   ##
========================================
  Coverage    99.02%   99.02%           
========================================
  Files          142      142           
  Lines         7262     7280   +18     
========================================
+ Hits          7191     7209   +18     
  Misses          71       71           
Files with missing lines Coverage Δ
include/boost/mysql/metadata.hpp 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 303b9f0...8f45ade. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@anarthal anarthal merged commit d56b4cd into develop Apr 5, 2025
6 checks passed
@anarthal anarthal deleted the feature/461-optimization-metadata-std-string branch April 5, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant