-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix -x option behavior #401
Conversation
Nice find, good edge case. |
Fix the lint and I'll accept - thanks |
3540cea
to
5b5ea73
Compare
Done. Also I streamlined the funcs so they all accept When running CI I noticed some tests are randomly failing, so I fixed that as well. Hope you don't mind the new changes. |
5b5ea73
to
4b82e1b
Compare
Thanks, Agree with the streamlining. Those tests, were new tests and I refactored them here: #404 - so we no longer need that part of your PR. - which now causes a conflict :-(. (Although I do like your use of |
This PR addresses an issue where `target_dirs` were being optimized out\ before being passed to the `get_filesystem_devices()` function. The changes in this PR ensure that `target_dirs` are passed directly to `get_filesystem_devices()`, and only then are they simplified. Example of a command that currently doesn't work correctly: ```sh dust -x $(findmnt -S tmpfs -o target -n) ``` It should show the usage of all tmpfs mounts, but it currently shows just the the root mountpoints like `/run`, since all the mountpoints nested under it are optimized out.
4b82e1b
to
09b8de9
Compare
Conflicts from those tests would be fine, but there were many complex conflicts from #399
|
This PR addresses an issue where
target_dirs
were being optimized out before being passed to theget_filesystem_devices()
function. The changes in this PR ensure thattarget_dirs
are passed directly toget_filesystem_devices()
, and only then are they simplified.Example of a command that currently doesn't work correctly:
dust -x $(findmnt -S tmpfs -o target -n)
It should show the usage of all tmpfs mounts, but it currently shows just the the root mountpoints like
/run
, since all the mountpoints nested under it are optimized out.