feat: Handle duplicate dir names better #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bootandy
force-pushed
the
same_dir_names2
branch
from
cf11af4 to
cc98fdf
Compare
bootandy
commented
Feb 6, 2025
| } else { | ||
| top_level_nodes | ||
| } | ||
| } |
There was a problem hiding this comment.
add a test for this using below dup_name folders
bootandy
force-pushed
the
same_dir_names2
branch
from
cc98fdf to
252bf23
Compare
If we run `dust /usr/*/Trash` We see several 'Trash' directories in the output but do not know which user they belong to. This fix means if we see duplicate names in a directory we will display the parent directory name as well
bootandy
force-pushed
the
same_dir_names2
branch
from
252bf23 to
759658e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we run
dust /usr/*/TrashWe see several 'Trash' directories in the output but do not know which user they belong to.
This fix means if we see duplicate names in a directory we will display the parent directory name as well
for: #441