WIP: Add script for converting Zephyr repository #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tleb
reviewed
Feb 24, 2025
tleb
reviewed
Feb 25, 2025
| copy_git_worktree() { | ||
| echo $1 $2 | ||
| rsync -q -av $1 --exclude .git $2 | ||
| } |
There was a problem hiding this comment.
What's the reasoning behind two Git directories? Could you use a single one instead and generate tags on it which have a prefix/suffix?
So maybe upstream pushes v1.0 and we add a new local tag called elixir-v1.0 (or whatever). Then the upper layers only pick those tags up?
tleb
reviewed
Feb 25, 2025
utils/zephyr-converter.sh
Outdated
| west_manifest=$TOP_DIR/$PROJECT_NAME/west.yml | ||
| if [[ -f $west_manifest ]]; then | ||
| # Find disabled groups | ||
| extra_groups=`cat west-topdir/zephyr/west.yml | yq -r '(.manifest."group-filter" // [])[]' | grep '^-' | sed 's/^-/+/' | paste -s -d,` |
There was a problem hiding this comment.
Use Python for YAML manipulation? This pipeline is hardly readable. eg
x='
import yaml
import sys
x = yaml.safe_load(sys.stdin)
# ...'
extra_groups="$(python -c "$x" < west-topdir/zephyr/west.yml)"
fstachura
force-pushed
the
zephyr-converter
branch
3 times, most recently
from
a086530 to
3c1af40
Compare
fstachura
force-pushed
the
zephyr-converter
branch
from
3c1af40 to
42ed877
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work-in-progress version of Zephyr repository converter discussed in #279. It's not integrated with Elixir in any way yet, I'm not sure what would the best way to approach this. For now, probably the
utils/indexscript could "inherit" functions fromprojectsdirectory scripts, likescript.shdoes. Zephyr-specific repository conversion part could be then placed inprojects/zephyr.sh.The script does not try to properly order commits in the target repository, I don't think it matters for Elixir.
In this version, all the extra projects are placed in
west_projectsdirectory. West by default places project directories in directory above Zephyr, but that is not going to work for Elixir, because it would break URLs.All west groups disabled in the manifest are enabled.
I have no experience with Zephyr, so I don't know if this makes sense.