#313 baton migration for argocd template changes #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
csun-cpointe
force-pushed
the
313-feature-baton-migration-for-argocd-template-changes
branch
2 times, most recently
from
a4d378b
to
4372505
Compare
ewilkins-csi
reviewed
Sep 6, 2024
| continue; | ||
| } | ||
|
|
||
| if (startSpecConfig && !line.isEmpty() && !line.startsWith(SPEC_INDENTION)) { |
There was a problem hiding this comment.
A: Probably better to use the same indentation detection logic as you wrote for the values file migration
ewilkins-csi
reviewed
Sep 6, 2024
| Then the template is unchanged | ||
|
|
||
| Scenario: A not ArgoCD application template is not impacted by this migration | ||
| Given a not application ArgoCD template |
There was a problem hiding this comment.
A:
Suggested change
| Given a not application ArgoCD template | |
| Given a template that is not an ArgoCD application |
ewilkins-csi
reviewed
Sep 6, 2024
| - CreateNamespace=true | ||
| - ApplyOutOfSyncOnly=true | ||
| automated: | ||
| prune |
There was a problem hiding this comment.
A: Because this is a yml list, the proper format would be to precede with -. Doesn't really matter much as we're just confirming that the content is preserved.
Edit: sorry got confused with syncOptions, would be prune: "". And the point still doesn't really matter haha
There was a problem hiding this comment.
ah this should be prune: true. Let me correct it
csun-cpointe
force-pushed
the
313-feature-baton-migration-for-argocd-template-changes
branch
from
4372505
to
617c933
Compare
csun-cpointe
deleted the
313-feature-baton-migration-for-argocd-template-changes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.