Contributing dotnet/Unity build and static code analysis steps #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* formatting * add suppression file support * update README * begin writing unit tests * fix tests * finish new unit tests * use null safe operator on config Co-authored-by: Steven Terrana <[email protected]>
…ry docs (boozallen#168) * add section for migrating from SDP 3.2 to 4.0 to NPM library docs * adding 4.0 migration info to Maven docs Co-authored-by: Peter Sigur <[email protected]>
* add config options to k8s library (boozallen#115) * [AIOPS-32] Adding in support, tests, and documentation for Maven (boozallen#118) * Added Grype * push grype readme * changed maven url to https * add ds_store to gitignore * Working on Grype spock tests * push GrtypeTestSpec * push readme/grype_scan changes * renamed grype_scan.groovy * additional change addressing scanning multi images * grype changes * updated grype image * add missing brace * fixed second use of file var * add scan_image * check path * test w/unstash * testing unstash * add var explicit type * add unstash/stash to docker.image.inside * move grype config check to docker.image.inside * change upCase vars to camelcase, added config vars * changed config var to snake case * import grype * allow fail severity to be none * test * test if * test if statement * allows other formats to not trigger error * test each loop relocation * test string concat * test json string concat * allow unique naming of archive items * fix var incorrect var name * test unique archives * fixed var declaration * fix var * test archival of multi scans * formatting * use img.context instead * formatting * throw multi errors * test exception * add throe exception * updates * Delete .DS_Store * delete test/maven * remove docs/modules/root * remove maven.groovy * fixed files * add blank line * unit testing grype * added inside_sdp_image helper * changed lib config option args * fixed called image name * test sdp image retrieval * test exception handling * fix loop * test login to registry * test reg login * test docker: source * test login to registry * test docker in grype * test using grype:0.38.0 * update readme * remove docker version * test echo msg * Push start of unit test * add newline * fixed readme * add grypeContainer var * updated dependancies * added optional grype_container * test img.repo * test contains * test if statement * test * test * removed if statement * retry if statement * test if statement * test retrieving img.repo with prefix * test repo name * test * concatenate * test echo var * concatenate strings * working string concat * testing for var scope * test assigning to null string * removed echo tests * check if new code broke multi image * put back if * remove json extension * work on grype config * test grypeConfig var * add new field to lib config * testing not null check * testing grype configs * test * test grype config check * test with build ARGS * test removed defaults * changed none to null * test * test config search * create local grype * test * test file create * checking dirs * test mkdir * is dir created * test * create test file * fix var name * whose running the container * remove echo grypeconfig * test * make gyrpe config * check home * build test * echo home * check home var * test * test * test * check dir * test * check groovy * test .grype * test * test * test again * check sev * test XDG var * test xdg * fixed var * check dir * test * test env var * test * test * test echo * test * testing * test export * remove sh test cmds * fixed miss var * test json w/o grype.yaml * test json and grypeconf null * Tidy up * formatting * removed empty lines 62/86 * changed HOME and XDG vars to string type * working tests * add more tests * input tests * push more tests * Exception test * remove empty else block * update Co-authored-by: steven-terrana <[email protected]> Co-authored-by: kdendtler <[email protected]> Co-authored-by: Connor <[email protected]>
…g where file extensions don't exist on generated reports (boozallen#170) * add config options to k8s library (boozallen#115) * [AIOPS-32] Adding in support, tests, and documentation for Maven (boozallen#118) * added defaults/added file extension naming * rm extra files/folders * rm folders * fix gitignore * fix gitignore whitespace * update unit tests Co-authored-by: steven-terrana <[email protected]> Co-authored-by: kdendtler <[email protected]>
* fixing filepath issues * additional string fix
…en#176) (boozallen#177) * Add catalog-info.yaml file * Fix name, update title
* add config options to k8s library (boozallen#115) * [AIOPS-32] Adding in support, tests, and documentation for Maven (boozallen#118) * add login_to_registry * changed brace/format * mock login_to_registry * rm unneeded files * rem/fix files from upstream merge * Update libraries/syft/steps/generate_sbom.groovy Co-authored-by: Peter Sigur <[email protected]> * linebreak * whitespace rm Co-authored-by: steven-terrana <[email protected]> Co-authored-by: kdendtler <[email protected]> Co-authored-by: Peter Sigur <[email protected]>
…zallen#182) Co-authored-by: jennifersheppard-bah <[email protected]>
* add config options to k8s library (boozallen#115) * [AIOPS-32] Adding in support, tests, and documentation for Maven (boozallen#118) * del maven junk * del old maven * remove docs/modules * test syft fix * test syft * testing sbom * update default sbom_container * fix gitignore * fix unit tests Co-authored-by: steven-terrana <[email protected]> Co-authored-by: kdendtler <[email protected]>
…len#184) * allow none severity * add none to lib config * update readme
* allow none severity * add none to lib config * update readme * bump version
…allen#186) * fix mistake in NPM readme * update NPM library to allow overriding the container image used
* implement new Yarn library * remove `yarn --version` call * fix mistake in test spec * fix failing tests
* push syft multi format * test for loop * test multi format syft * check for report output * fix increment operator * fix sbom_format data type * remove sbom_format default * test sbom_format.size() * ts for loop * testing loop * fix equal operator == * testing loop * check args * ts list * ts ARGS * remove size() * loop troubleshoot * Test using ArrayList * comment out loops * print loop index * test with string concatenation * rm println * test toString * test arraylist * test * test * test ARG building * testing * test w/o tostring * test * move sbom_format to LinkedHashMap for extensions * check sbom_format * test * fix lib conf * revert to ArrayList for sbom_format var * fixed lib config * rm ! from index identifier * fix format * test * ts stdout * comment out erring cmd * missed end " * rm extra text * test --output * check ARGS * test * add space for multi outputs * add formatter var * ts formatter * add space * cmd formatting * archival ts * test archival * trim trailing comma * escape the $ * test if statements * fixes * add exception handling * test exception * skip archival if failed * echo exception * test * test err * test echo err * test error * exception test * test throw err * test error * test * test error * add shouldFail bool * Syft Unit test changes * push syft Unit tests * update syft docs * Fixed artifacts archival * rm unused execption var * updates README file
ConnorDY
requested changes
Nov 7, 2022
There was a problem hiding this comment.
Hello! 👋
It looks like this branch is a good bit behind our develop branch. This is making the diff on GitHub show a lot more than what you've actually changed.
Could you merge our develop branch into your branch for this PR and resolve any potential merge conflicts? This should remedy the problem and make it much easier for us to review your PR.
Let me know if you need any help with this. 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Added steps to the dotnet and Sonarqube libraries to build and run static code analysis on dotnet/Unity projects.
Description
Added steps to the dotnet and Sonarqube libraries to build and run static code analysis on dotnet/Unity projects.
How Has This Been Tested
The libraries have been tested on dotnet and Unity project pipelines.
Types of Changes
Checklist