Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support withMaven step #215

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maxime-michel
Copy link

PR Details

We use the pretty useful Pipeline Maven Integration plugin to run Maven jobs. One of its features is that when you wrap your Maven execution with withMaven, which the plugin provides, it spies on the generated artifacts and then stores their GAV in a DB. Thanks to that information it's then able to trigger downstream SNAPSHOT projects on the same instance automatically. This is vital in our setup but we also very much enjoy what the SDP Maven library offers out of the box, so we thought to add support for the plugin right here.

Description

The PR adds an optional withMavenParams field to the step configuration. As soon as the map contains a property, and only if the map contains anything, the Maven invocation is then wrapped with the withMaven step (which requires the plugin to be installed).

How Has This Been Tested

I have configured a local Jenkins instance to use my fork of the libraries and confirmed that defining this parameter wraps the Maven execution with withMaven, whereas not defining it leaves the build unchanged.

Types of Changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I am submitting this pull request to the appropriate branch
  • I have labeled this pull request appropriately
  • I have updated the documentation accordingly.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant