Upgrade and unpin python dependencies #921
Conversation
bartsanchez
force-pushed
the
bart/upgrade-dependencies
branch
from
d7fd33a to
75d083d
Compare
| @@ -33,15 +33,15 @@ python = "^3.12" | |||
|
|
|||
| [tool.poetry.group.dev.dependencies] | |||
| pytest = "*" | |||
| bump2version = "^1.0.0" | |||
There was a problem hiding this comment.
I'm unsure about this strategy.
I.e. mypy ^1.0.0 is equivalent to 1.*. Leaving the door open that way can break many things.
And even doing that, you will have to poetry update from time to time.
In other words: I would pin the major versions (as with mypy) and do a poetry update periodically to upgrade the .lock file.
There was a problem hiding this comment.
Since you have a lockfile you can't break anything until you execute the poetry update command. The version is already pinned in the lock file. See this as an example.
I would say the purpose of the lockfile is to pin the versions, so I don't see the point of also pin them in the pyproject (unless there is version that really breaks your code and then you can pin in the pyproject until you fix the issue).
Right now, by unpinning them there are no tests failing. This does not mean that there are no bugs but, unless you pin the versions forever you will end up discovering them at some point.
However, feel free to close this PR if you think it's not helping.
No description provided.