-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
143 refactor notch approximation #150
Open
johannes-mueller
wants to merge
17
commits into
develop
Choose a base branch
from
143-refactor-notch-approximation
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Mueller <[email protected]>
Signed-off-by: Johannes Mueller <[email protected]>
Signed-off-by: Johannes Mueller <[email protected]>
Signed-off-by: Johannes Mueller <[email protected]>
Signed-off-by: Johannes Mueller <[email protected]>
Signed-off-by: Johannes Mueller <[email protected]>
Signed-off-by: Johannes Mueller <[email protected]>
The LUTs are implementation details and should not be accessed directly by tests. Signed-off-by: Johannes Mueller <[email protected]>
Signed-off-by: Johannes Mueller <[email protected]>
Signed-off-by: Johannes Mueller <[email protected]>
Signed-off-by: Johannes Mueller <[email protected]>
Signed-off-by: Johannes Mueller <[email protected]>
Signed-off-by: Johannes Mueller <[email protected]>
Signed-off-by: Johannes Mueller <[email protected]>
Signed-off-by: Johannes Mueller <[email protected]>
Signed-off-by: Johannes Mueller <[email protected]>
Signed-off-by: Johannes Mueller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #143
In a nutshell:
NotchApproxBinner
new class to do the binning for the notch approximation.NotchApproximationLawBase.primary
andNotchApproximationLawBase.secondary
in order to be able to get stress strain data in only one lookup.load
argument can be dropped in the methods for strain calculation.NotchApproximationBinner
has the method.initialize
to set the maximum load. That means, that determining the maximum load can be left toFKMRainflowDetector
.Binned
class in favor ofNotchApproxBinner
tests/strength/fkm_nonlinear/test_fkm_nonlinear.py
had to be dropped because they were using internals ofBinned
.This adds a performance boost of roughly factor 10.
Open point
As we now do no longer need to precondition the binner with the maximum load, we need to rethink the role of
"max_load_independently_for_nodes"
in the assessment parameters and find a neat way how to handle it. This will be treated in a follow up issue.@maierbn take your time to review, no rush. We can discuss details after the winter break. I put some effort into arranging the commits in a meaningful way. So reviewing them individually might be easier to understand what's going on.