Add experimental environment variable to opt out of 100 continue with empty body #3123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3123 +/- ##
========================================
Coverage 93.14% 93.14%
========================================
Files 66 66
Lines 14237 14240 +3
========================================
+ Hits 13261 13264 +3
Misses 976 976 ☔ View full report in Codecov by Sentry. |
nateprewitt
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
We should note in the PR overview that this is not a GA feature and is subject to abrupt breaking changes.
Otherwise, this looks good, thanks @SamRemis!
This was referenced Feb 23, 2024
Closed
aws-sdk-python-automation
added a commit
that referenced
this pull request
Feb 27, 2024
* release-1.34.51: Bumping version to 1.34.51 Update to latest models Add experimental environment variable to opt out of 100 continue with empty body (#3123)
hswong3i
pushed a commit
to alvistack/boto-botocore
that referenced
this pull request
Feb 28, 2024
… empty body (boto#3123) Add experimental flag for checking the request body before setting 100 continue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the header
BOTO_EXPERIMENTAL__NO_EMPTY_CONTINUE; when enabled, we will make a best effort to inspect the size of the body and only add the 100 continue header if the body is non-empty.Note: this feature is marked as experimental and the functionality and may be altered or removed in a minor patch without warning. Users relying on this feature should strictly pin their botocore version.