Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ruff, fix issues, use ruff for import sorting #3380

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

akx
Copy link
Contributor

@akx akx commented Feb 7, 2025

This PR:

  • upgrades the version of Ruff used from 0.4.8 to 0.9.4
  • copies the exclude rules from pre-commit configuration to the Ruff configuration, to make it possible to run ruff outside of pre-commit
  • reapplies ruff format (mechanical)
  • fixes other new complaints surfaced by the new version of Ruff
  • gets rid of isort for import sorting in favor of just ruff's I rule.
    • This had some manual work go into it, to keep the context of the noqa comments intact.

@akx akx force-pushed the upruff branch 2 times, most recently from 5bd03ed to 970dc0e Compare February 7, 2025 06:52
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (develop@976b894). Learn more about missing BASE report.
Report is 177 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #3380   +/-   ##
==========================================
  Coverage           ?   93.03%           
==========================================
  Files              ?       66           
  Lines              ?    14452           
  Branches           ?        0           
==========================================
  Hits               ?    13446           
  Misses             ?     1006           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants