Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Related: bottlerocket-os/bottlerocket-sdk#244
Description of changes:
%optflags
is the result of augmenting%__global_compiler_flags
with arch-specific flags. These may not work when cross-compiling as the target arch may not match the host arch.Switch to the baseline
%__global_compiler_flags
instead. These flags are only relevant when compiling software for the host, which should not be included in the final set of packaged artifacts, so any missed optimizations are not a concern.Testing done:
Before this change, cross-compiling for x86_64 on an aarch64 build host fails with this error:
After, the build succeeds.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.