Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve file not found error when center features path isn't absolute #201

Closed
wants to merge 1 commit into from
Closed

Resolve file not found error when center features path isn't absolute #201

wants to merge 1 commit into from

Conversation

roblaine
Copy link

Resolves an issue related to passing an argument to --center-features flag for cluster.py.

See discussion on #195 for related information.

@justinrporter feel free to edit the PR as required. 😄

@justinrporter
Copy link
Collaborator

Thanks for making this PR!

One question... what happens if I use a path like ../path/to/thing? It's not absolute, but there's no need to mess with it, right?

@justinrporter justinrporter linked an issue Jun 11, 2020 that may be closed by this pull request
@roblaine
Copy link
Author

Let me double check and sure it doesn't cause any issues

@justinrporter
Copy link
Collaborator

If you run in to trouble, an alternative strategy would be just to check outdirs to see if it's the empty string (e.g. if outdirs:) before calling os.makedirs to create non-existing directories.

@roblaine roblaine closed this by deleting the head repository Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cluster.py fails if paths have no directory spec
2 participants