Subsample features #235
Closed
Subsample features #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Temporarily closing this as there are more changes that should be added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #232 by:
cluster.pypreventing passing both subsample and features.I wonder if it's also worth looking at file handling for features files? I noticed the loader is expecting a h5 file if only one set of features is passed, but a series of numpy files if multiple are passed. @justinrporter do you know why this was preferred? I could try and add some file extension logic as it might be nice to pass multiple h5 files (e.g. multiple ragged datasets), or a single numpy file (single homogenous dataset). Happy to do this as the same or a separate PR.