Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Drop support old Node version #548

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Conversation

congminh1254
Copy link
Member

No description provided.

@congminh1254 congminh1254 changed the base branch from support-ai-apis to main October 21, 2024 16:55
@congminh1254 congminh1254 changed the base branch from main to support-ai-apis October 22, 2024 14:34
@arjankowski
Copy link
Contributor

The commit should be marked as a breaking change because of dropping support for node.
So we have to add the !:
feat!: Drop support old Node version

"scripts": {
"test": "nyc mocha \"test/**/*.test.js\"",
"posttest": "npm run lint",
"lint": "eslint --fix ./src ./test",
"prepack": "oclif-dev manifest && oclif-dev readme --multi && npm shrinkwrap && git checkout origin/main -- package-lock.json",
"postpack": "rm -f oclif.manifest.json && rm -f npm-shrinkwrap.json",
"version": "oclif-dev readme --multi && git add README.md && git add docs",
"build": "oclif-dev pack:macos && rm -rf tmp/ && oclif-dev pack:win && rm -rf tmp/ && npm run binaries",
"binaries": "pkg --targets node12-macos-x64,node12-win-x64,node12-linux-x64 --out-path ./dist .",
"build": "oclif-dev pack:macos && rm -rf tmp/ && oclif-dev pack:win && rm -rf tmp/",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested the whole process of releasing on jenkins?

README.md Outdated Show resolved Hide resolved
@congminh1254
Copy link
Member Author

The commit should be marked as a breaking change because of dropping support for node. So we have to add the !: feat!: Drop support old Node version

This is a PR to the feature branch major-version, so I think the ! should be added when the feature branch merge to main later.

@arjankowski arjankowski changed the title feat: Drop support old Node version feat!: Drop support old Node version Oct 23, 2024
arjankowski
arjankowski previously approved these changes Oct 23, 2024
Copy link

stale bot commented Nov 23, 2024

This issue has been automatically marked as stale because it has not been updated in the last 30 days. It will be closed if no further activity occurs within the next 7 days. Feel free to reach out or mention Box SDK team member for further help and resources if they are needed.

@stale stale bot added the stale label Nov 23, 2024
Copy link

stale bot commented Nov 30, 2024

This issue has been automatically closed due to maximum period of being stale. Thank you for your contribution to Box CLI and feel free to open another PR/issue at any time.

@stale stale bot closed this Nov 30, 2024
@congminh1254 congminh1254 added dontstale For stalebot to keep the issue open and removed stale labels Dec 2, 2024
@congminh1254 congminh1254 reopened this Dec 2, 2024
@congminh1254 congminh1254 changed the base branch from major-version to main December 4, 2024 15:37
@congminh1254 congminh1254 dismissed arjankowski’s stale review December 4, 2024 15:37

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dontstale For stalebot to keep the issue open
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants