This repository has been archived by the owner on May 26, 2022. It is now read-only.
Add Docker files and documentation #840
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmleroux
commented
Nov 10, 2021
Comment on lines
+302
to
+304
| if (!$foundCommaLocale) { | ||
| $this->markTestSkipped('No locale with comma decimal separator'); | ||
| } |
There was a problem hiding this comment.
This can happen on system without comma separator
jmleroux
commented
Nov 10, 2021
| RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \ | ||
| libzip-dev \ | ||
| locales \ | ||
| locales-all \ |
There was a problem hiding this comment.
Add locales for comma separator tests
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't have PHP 7.2 on my machine and had to use Docker to run unit tests