Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Removed the hardcoding of the 2019.2.2 version for "latest" when installing the "salt" configuration management tool #252

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

arizvisa
Copy link
Contributor

Due to issue saltstack/salt#1394 which broke the "latest" parameter to salt-bootstrap, we were forced to explicitly test for it and hardcode the version. As that aforementioned issue was finally closed, this means we can remove this hardcoding from script/cmtool.bat entirely.

The majority of that hardcoding was done by commit 9645c59. so we can get by with reverting it and fixing a few things in order to remain consistent. There's still an ssl issue since earlier versions of windows do not support ssl versions earlier than 3. In order to deal with this other issue, this PR adds another script which installs KB3154518 on the platforms that it's necessary for.

This closes issue #251.

@arizvisa arizvisa added enhancement This will introduce or improve an already existing capability PR Priority (3) -- Minor This PR refactors a particular component (no major side effects), or introduces a cool feature labels Jul 16, 2020
@arizvisa arizvisa self-assigned this Jul 16, 2020
@arizvisa arizvisa changed the title [WIP] Removed the hardcoding of the latest version to 2019.2.2 when installing the "salt" configuration management tool [WIP] Removed the hardcoding of the 2019.2.2 version for "latest" when installing the "salt" configuration management tool Jul 16, 2020
@arizvisa
Copy link
Contributor Author

force-pushed due to rebase after merging of PR #254.

@arizvisa
Copy link
Contributor Author

arizvisa commented Jul 19, 2020

This PR is only being held up atm because I still haven't tested this properly against W7. I'm currently on the edge of considering adding another KB due to the latest version of saltstack not bundling a non-SP1 compatible update for W7.

We either need a W7 SP1 evaluation/rtm iso link, or some other way to install the saltstack package without SP1 being installed (similar to the way I'm doing KB2999226). As mentioned, I'm kind of up-in-the-air about this and am considering just warning the user about later versions of SaltStack having potential issues on W7 or maybe fixing it with documentation. I currently have a friend looking into this since he's got msdn accts and stuff, so I'll update this PR when I get some more information from him.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This will introduce or improve an already existing capability PR Priority (3) -- Minor This PR refactors a particular component (no major side effects), or introduces a cool feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating the saltstack version deployed by script/cmtool.bat from 2019.2.2 to the "latest"
1 participant