Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: migrate to monorepo #138

Merged
merged 3 commits into from
Oct 2, 2024
Merged

refactor: migrate to monorepo #138

merged 3 commits into from
Oct 2, 2024

Conversation

VmMad
Copy link
Member

@VmMad VmMad commented Oct 1, 2024 •
edited by begonaalvarezd
Loading

Close #139

@VmMad VmMad requested a review from evavirseda October 1, 2024 12:51
evavirseda
evavirseda approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks really good! I’d just suggest renaming the core folder to shared, I prefer this, but feel free to change it or not ✌️

@begonaalvarezd begonaalvarezd changed the title feat: migrate to monorepo refactor: migrate to monorepo Oct 2, 2024
@begonaalvarezd begonaalvarezd merged commit e0d66cf into main Oct 2, 2024
1 check passed
@begonaalvarezd begonaalvarezd deleted the feat/migrate-to-monorepo-v2 branch October 2, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evavirseda evavirseda evavirseda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Port project to monorepo
3 participants
@VmMad @evavirseda @begonaalvarezd