Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add general react support #142

Merged
merged 10 commits into from
Oct 9, 2024
Merged

feat: add general react support #142

merged 10 commits into from
Oct 9, 2024

Conversation

VmMad
Copy link
Member

@VmMad VmMad commented Oct 3, 2024

Fixes #140

evavirseda
evavirseda requested changes Oct 4, 2024
View reviewed changes
Copy link
Member

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting an error after build 🙏
image

evavirseda
evavirseda approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks amazing, just one thing 🙏
can you add .svelte-kit to the .gitignore file?

@begonaalvarezd begonaalvarezd merged commit 6fb51f6 into main Oct 9, 2024
1 check passed
@begonaalvarezd begonaalvarezd deleted the feat/add-react-support branch October 9, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evavirseda evavirseda evavirseda approved these changes

@begonaalvarezd begonaalvarezd Awaiting requested review from begonaalvarezd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Extend support for Next.js
3 participants
@VmMad @evavirseda @begonaalvarezd